feat: implements css to html file in Chanels Lesson 22 #547
+1,473
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VicenteVigueras
requested changes
Apr 29, 2025
anthonydmays
requested changes
Apr 30, 2025
| <section class="programs-section"> | ||
| <h2>Our <em class="highlight">Programs</em></h2> | ||
| <ul class="programs"> | ||
| <li class="program"> |
There was a problem hiding this comment.
The program descriptions are shown as a grid in cards. Would be nice to see that reflected in your design.
| <article> | ||
| <section class="hero-section"> | ||
| <div class="hero-overlay"></div> | ||
| <div class="hero-content"> |
There was a problem hiding this comment.
The hero content block is left aligned, but I see it's right aligned for you.
|
Ok I'll correct the issue
…On Tue, Apr 29, 2025, 10:47 PM Anthony D. Mays ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In lesson_22/chanel_mock_site/index.html
<#547 (comment)>
:
> + </div>
+ </header>
+ <div class="main">
+ <div class="content">
+ <article>
+ <section class="hero-section">
+ <div class="hero-overlay"></div>
+ <div class="hero-content">
+ <h2 class="hero-title">Together we can move the needle of <em class="highlight">diversity in tech.</em></h2>
+ <div class="hero-text"><span>Code Differently</span> provides hands on training and education through coding classes that gives participants the technical and cognitive skills they need to excel in technology-driven workplaces.</div>
+ </div>
+ </section>
+ <section class="programs-section">
+ <h2>Our <em class="highlight">Programs</em></h2>
+ <ul class="programs">
+ <li class="program">
The program descriptions are shown as a grid in cards. Would be nice to
see that reflected in your design.
------------------------------
In lesson_22/chanel_mock_site/index.html
<#547 (comment)>
:
> + </div>
+ <ul class="header-top-menu">
+ <li><a href="#">Home</a></li>
+ <li><a href="#">About</a></li>
+ <li><a href="#">Contact</a></li>
+ </ul>
+ <div class="header-cta">
+ <a class="sign-up-button" href="#">Sign Up</a>
+ </div>
+ </header>
+ <div class="main">
+ <div class="content">
+ <article>
+ <section class="hero-section">
+ <div class="hero-overlay"></div>
+ <div class="hero-content">
The hero content block is left aligned, but I see it's right aligned for
you.
—
Reply to this email directly, view it on GitHub
<#547 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQBJ6TMXDDKENMCA7CU5M4L24A2STAVCNFSM6AAAAAB33RK7ZSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMBVGU4DCMRUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the header and styled the hero img with the text provided.